forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest merge #2
Merged
Merged
Latest merge #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
App Icon update for WPV v3
App Icon Update
Reviewed By: lexs Differential Revision: D2857580 fb-gh-sync-id: f3172cecb8f4563c70564a50c2e9f42178af347a
Summary: public When using dev menu - elements inspector, a yellow box appears with React warning regarding missing key prop in elements array. This commit fixes this issue. Reviewed By: martinbigio Differential Revision: D2835332 fb-gh-sync-id: 3fcb37dfb6bdcff3788963b36416b7da190b9a84
Reviewed By: chaceliang Differential Revision: D2863157 fb-gh-sync-id: ca73545303607333fe32cd8e2e8f040134ee1d24
Summary: public NSJSONSerialization throws an exception when it encounters bad JSON data, including NaN values, which may not be a programming error. This diff adds code to catch those exceptions and convert to an error. Also, if no error handling is in place, RCTJSONStringify will now display a redbox, and attempt to recover by sanitizing the JSON data and retrying. Reviewed By: javache Differential Revision: D2854778 fb-gh-sync-id: 18e6990af0d91083496d6a0b75c31a94ed9454a5
Summary: Following up on the conversation in https://www.prod.facebook.com/groups/reactnativeoss/permalink/1516993445263951/ I currently don't see any good reason to create an offline bundle for simulator builds. Closes #5519 Reviewed By: svcscm Differential Revision: D2859751 Pulled By: mkonicek fb-gh-sync-id: f70481e447e258f5531de773729fc31d9ebec6f7
Reviewed By: bestander Differential Revision: D2856486 fb-gh-sync-id: 0bb81136289e2f121387649765ba682103e4701b
Reviewed By: davidaurelio Differential Revision: D2862315 fb-gh-sync-id: 03728a2593b477aef3bbfe01d42382893a05ea50
Reviewed By: voideanvalue Differential Revision: D2862332 fb-gh-sync-id: 19ab5e8a580137ffe6276b21a9018f7b322dd0cb
Summary: I *think* this is causing a crash for me in a release build (curiously, not a debug build): ``` ReferenceError: Can't find variable: self ``` I saw this in 0.18.1, which I assume was renamed to v0.19.0-rc. Closes #5562 Reviewed By: svcscm Differential Revision: D2866491 Pulled By: androidtrunkagent fb-gh-sync-id: 196f718bf807c5eef676f66f1e15d7bde9475d5b
Summary: A promise based API for handling Link for Android and iOS. Refer #4971 The iOS part doesn't handle errors. Will need someone with iOS knowledge to do that. cc skevy ide brentvatne mkonicek vjeux nicklockwood Closes #5336 Reviewed By: svcscm Differential Revision: D2866664 Pulled By: androidtrunkagent fb-gh-sync-id: 67e68a827e6b85886bfa84e79b897f079e78b1b5
Summary: assign webView’s delegate to nil when the delegate release Closes #5574 Reviewed By: svcscm Differential Revision: D2869485 Pulled By: nicklockwood fb-gh-sync-id: c72ac64e6c8757a2095d4e5d7baa3a0b6bded6ce
added ShareHows app android link in showcase
Summary: This adds the first of the three 3dTouch API types, that found on the touch event. It adds the `force` prop to touch events when running on iOS 9 devices: Closes #3055 Reviewed By: svcscm Differential Revision: D2860540 Pulled By: nicklockwood fb-gh-sync-id: 95a3eb433837c844f755b3ed4a3dfcb28452c284
Reviewed By: foghina, mkonicek Differential Revision: D2865561 fb-gh-sync-id: 7aab67d205b94d657a6ec7bf81a4ecee644eabc2
Reviewed By: javache Differential Revision: D2858983 fb-gh-sync-id: b73de54163d7b75891cb00be96ffb4556d3311a3
Summary: Closes #5582 Reviewed By: svcscm Differential Revision: D2869861 Pulled By: androidtrunkagent fb-gh-sync-id: 5b004521e11d0e55c237183e69f8251732c6bd14
Summary: public This diff improves the implementation of 3D touch by adding a `forceTouchAvailable` constant to View that can be used to check if the feature is supported. I've also added an example of how you can use the `force` property of the touch event to measure touch pressure in React Native. Reviewed By: vjeux Differential Revision: D2864926 fb-gh-sync-id: 754c54989212ce4e4863716ceaba59673f0bb29d
Summary: Hi, The doc wording was adapted from https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIScrollView_Class/#//apple_ref/doc/c_ref/UIScrollViewIndicatorStyle Note that the iOS doc is misleading, and `UIScrollViewIndicatorStyleDefault` is the same as `UIScrollViewIndicatorStyleBlack` (since iOS 7 I think). Let me know what you think. Closes #5583 Reviewed By: svcscm Differential Revision: D2870011 Pulled By: nicklockwood fb-gh-sync-id: d28a96e1a2d4610cbeaee0ae70108ab9d9f05fdb
Reviewed By: mkonicek Differential Revision: D2869751 fb-gh-sync-id: 862c266601dd83ca3bf9c9bcbf107f7b17b8bdfd
Reviewed By: martinbigio Differential Revision: D2862821 fb-gh-sync-id: d763985cc499fc49d7ed1b25341d19b80e1be55d
Summary: After the release of 0.14, static images should be placed in the source code tree and then required as explained in the [Images guide] (https://facebook.github.io/react-native/docs/images.html). This pull request updates the image documentation and examples to the new asset system. UIExplorer tested on iOS and Android. Closes #4987 Reviewed By: svcscm Differential Revision: D2796276 Pulled By: bestander fb-gh-sync-id: 732ffa2f136391bb8a3e40a54b5b1ff5022c97f2
Summary: public To make sourcemaps work on Hot Loading work, we'll need to be able to serve them for each module that is dynamically replaced. To do so we introduced a new parameter to the bundler, namely `entryModuleOnly` to decide whether or not to process the full dependency tree or just the module associated to the entry file. Also we need to add `//sourceMappingURL` to the HMR updates so that in case of an error the runtime retrieves the sourcemaps for the file on which an error occurred from the server. Finally, we need to refactor a bit how we load the HMR updates into JSC. Unfortunately, if the code is eval'ed when an error is thrown, the line and column number are missing. This is a bug/missing feature in JSC. To walkaround the issue we need to eval the code on native. This adds a bit of complexity to HMR as for both platforms we'll have to have a thin module to inject code but I don't see any other alternative. when debugging this is not needed as Chrome supports sourceMappingURLs on eval'ed code Reviewed By: javache Differential Revision: D2841788 fb-gh-sync-id: ad9370d26894527a151cea722463e694c670227e
Reviewed By: frantic Differential Revision: D2870105 fb-gh-sync-id: c95db83e40b3558c53614b08240a5361c14e0e6c
Summary: Added a subset of the global flow types from the fbjs eslint config to remove the no-undef errors for flow types as well as a few missing browser globals that were used in the codebase. I also added a .eslintrc file to Examples to allow using alert there without warnings. Closes #5585 Reviewed By: svcscm Differential Revision: D2872016 Pulled By: vjeux fb-gh-sync-id: f9b1b511289425393074b7237049dec38ea407b6
Summary: An initial implementation was done on css-layout but isn't working correctly on many cases. The binding from React Native has been removed a long time ago. Let's not confuse people and remove it from the docs :) Closes #5522 Reviewed By: svcscm Differential Revision: D2859665 Pulled By: vjeux fb-gh-sync-id: 4aa008dd93a6cea6b79a7bce444c94148791eee4
Summary: This was driving me crazy :p Turns out that if the value is `'auto' /* default */`, then the docparser will not only trim the comment but also normalize the quote to double quote. This is not pretty but does the job. Closes #5509 Reviewed By: svcscm Differential Revision: D2872482 Pulled By: vjeux fb-gh-sync-id: 8ba5dad695f747f82b7680ee26bdc0792e21ea8f
Reviewed By: cpojer Differential Revision: D2872990 fb-gh-sync-id: 34c644ec79b424954a14e049b996c658f6b69610
Summary: The basic API is consistent with iOS; there are several platform-specific props. Also fixed the flickering when a value is selected. public Reviewed By: bestander Differential Revision: D2871092 fb-gh-sync-id: f5cdf6858cb7344b28ee46954cb6b0a3b144b646
Summary: public This diff adds support for providing custom scaletypes to Drawee. The implementation for the preexisting scale types is preserved. Breaking changes should be minimal. In fact, only direct usages of `ScalingUtils.getTransform(..., scaleType)` should be converted to `scaleType.getTransform(...)`. Reviewed By: kirwan Differential Revision: D2862911 fb-gh-sync-id: ab0355fd13544dc08ce4481eda87287404ea7adb
Summary: For my project it was required to receive a notification when the MapView annotation was deselected. So I renamed `onAnnotationPress` to `onAnnotationSelected` and added a new method `onAnnotationDeselected`, this names was "inspired" by the underlaying iOS API. The old API was still called and marked as deprecated. But maybe you have an idea for a better naming (onAnnotationFocus/-Blur?) -- or should a deselected call the press method again without an annotation (undefined)? Closes #5167 Reviewed By: svcscm Differential Revision: D2869695 Pulled By: nicklockwood fb-gh-sync-id: 91795ac3f1e4533b250af8901534d8870729d9db
Summary: **Problem:** As I was trying to document what color formats we supported, I realized that our current implementation based on the open source project tinycolor supported some crazy things. A few examples that were all valid: ``` tinycolor('abc') tinycolor(' #abc ') tinycolor('##abc') tinycolor('rgb 255 0 0') tinycolor('RGBA(0, 1, 2)') tinycolor('rgb (0, 1, 2)') tinycolor('hsv(0, 1, 2)') tinycolor({r: 10, g: 10, b: 10}) tinycolor('hsl(1%, 2, 3)') tinycolor('rgb(1.0, 2.0, 3.0)') tinycolor('rgb(1%, 2%, 3%)') ``` The integrations of tinycolor were also really bad. processColor added "support" for pure numbers and an array of colors!?? ColorPropTypes did some crazy trim().toString() and repeated a bad error message twice. **Solution:** While iteratively cleaning the file, I eventually ended up reimplementing it entierly. Major changes are: - The API is now dead simple: returns null if it doesn't parse or returns the int32 representation of the color - Stricter parsing of at Closes #5529 Reviewed By: svcscm Differential Revision: D2872015 Pulled By: nicklockwood fb-gh-sync-id: df78244eefce6cf8e8ed2ea51f58d6b232de16f9
Summary: public At the moment, when the user changes a file we end up pulling the dependencies of the entry point to build the bundle. This could take a long time if the bundle is big. To avoid it, lets introduce a new parameter to `getDependencies` to be able to avoid processing the modules recursively and reuse the resolution responseto build the bundle. Reviewed By: davidaurelio Differential Revision: D2862850 fb-gh-sync-id: b8ae2b811a8ae9aec5612f9655d1c762671ce730
Summary: public The HMR listener needs to be invoked on the non debounced callback to avoid loosing updates if 2 files are updated within the debounce configured time. Also, improve the time it takes to send HMR updates by avoiding rebuilding the bundle when the listener is defined. Instead just invalidate the bundles cache so that if the user reloads or disables Hot Loading the packager rebuilds the requested bundle. Reviewed By: davidaurelio Differential Revision: D2863141 fb-gh-sync-id: 3ab500eacbd4a2e4b63619755e5eabf8afdd1db9
Reviewed By: balazsbalazs Differential Revision: D2879926 fb-gh-sync-id: 9f833c209128eaa00b111387ee57dbbc6b74fcb7
Summary: This change fixes a bug in getTopOffsetForItem method of RecyclerViewBackedScrollView that was causing Y offset of onScroll events to be invalid when user would scroll up. I'm also adding some comments to this method which may help to understand its complexity. Closes #5610 Reviewed By: svcscm Differential Revision: D2880743 Pulled By: androidtrunkagent fb-gh-sync-id: 7183e3d6760fab5683afc49d454864239260fb91
Reviewed By: oli Differential Revision: D2880630 fb-gh-sync-id: bd31395abc69750f16a6ab32d11c55af3ec985a4
Summary: Closes #5626 Reviewed By: svcscm Differential Revision: D2881020 Pulled By: androidtrunkagent fb-gh-sync-id: 7f472d554a334f39c4b85ccfa4db81b7c3f41d38
Reviewed By: yungsters, spicyj Differential Revision: D2875010 fb-gh-sync-id: d316d5befd0d978bded99f70b814dc133c85b40f
…ger') Summary: public Due to the cross-platform polyfills we have added (and will add in future) to `UIManager.js`, accessing UIManager directly via NativeModules instead of importing the wrapper is discouraged. This diff fixes a few places where we were doing this inside our own modules. Note: As a general policy, we should avoid accessing modules via NativeModules anyway. Using wrapper classes allows us to provide static declarations for all the native methods and properties, which can be checked at build time by flow. If we access the modules directly, those interfaces are only known at runtime. Reviewed By: vjeux Differential Revision: D2881300 fb-gh-sync-id: 6737358ea8ea6d722cc1941a4b9fa0123a87fc29
Reviewed By: mkonicek Differential Revision:D2883844 Ninja: Only docs and React Native website, doesn't affect any fb apps fb-gh-sync-id: 4bf56dc695224f172832ca5381cebceab9e5fe4f
Summary: - Now using a table layout. While having the link inside of the header worked well in the browser, the search API would put "Edit in GitHub" as part of the title -_- - Instead of putting the link inside of every section like Props, put it on the page header. This makes it less repetetitive and also works on API pages where the link was absent before - Remove "Run this example" link as there's a giant Run this example sidebar already. Closes #5643 Reviewed By: svcscm Differential Revision: D2883989 Pulled By: vjeux fb-gh-sync-id: e810e1677d5130692997dd301d6d59cfe04b948f
Summary: Both LinkingIOS and IntentAndroid are deprecated in favor of Linking but it was not in the website documentation. Closes #5642 Reviewed By: svcscm Differential Revision: D2883999 Pulled By: androidtrunkagent fb-gh-sync-id: cd2ce6192f84fffef7ab7d4e56f87eb55fb30901
Summary: Closes #5647 Reviewed By: svcscm Differential Revision: D2884241 Pulled By: androidtrunkagent fb-gh-sync-id: 115491270c8f84d45f67a1a477543d9ace76f447
Summary: Closes #5648 Reviewed By: svcscm Differential Revision: D2884296 Pulled By: androidtrunkagent fb-gh-sync-id: 50340c0fc06926fbb3dc41c3078aa985ff48ccd3
Summary: `react-native-xcode.sh` can fail to execute if `$REACT_NATIVE_DIR` contains spaces. E.g. if `$REACT_NATIVE_DIR` was `/Users/samn/src/Xcode Projects/AwesomeReact` then `react-native-xcode.sh` would fail with the following error: ``` node /Users/samn/src/Xcode Projects/ReactNativeBeaconTest/node_modules/react-native/local-cli/cli.js bundle .... (elided) module.js:341 throw err; ^ Error: Cannot find module '/Users/samn/src/Xcode' at Function.Module._resolveFilename (module.js:339:15) at Function.Module._load (module.js:290:25) at Function.Module.runMain (module.js:447:10) at startup (node.js:139:18) at node.js:999:3 Command /bin/sh failed with exit code 1 ``` This change properly handles paths with spaces in them by quoting `$REACT_NATIVE_DIR` Closes #5651 Reviewed By: svcscm Differential Revision: D2884600 Pulled By: androidtrunkagent fb-gh-sync-id: 3784d8f4e16c0c2cadac738c5f085a5023b5ecf7
Summary: This section was outdated with older website : https://facebook.github.io/react-native/docs/known-issues.html#using-3rd-party-native-modules Closes #5650 Reviewed By: svcscm Differential Revision: D2884630 Pulled By: androidtrunkagent fb-gh-sync-id: afe35817421e055e343233a1db863954d6f75f01
Summary: Animating colors using Animated is currently interpolating rgb and rgba and doesn't round the intermediate values. We need to fix it there but it's not a straightforward change so reverting to the lax version here until we fix it inside of Animated (which is needed to work on web anyway). Closes #5654 Reviewed By: svcscm Differential Revision: D2885051 Pulled By: vjeux fb-gh-sync-id: dab69b1da11131c9fab2fd08c434c73ec93d59d2
Summary: Jest needs this for efficient caching of resolution responses. public Reviewed By: voideanvalue Differential Revision: D2873291 fb-gh-sync-id: fee27d2ffdfe64bd68fdb4d9e4259e721b33631f
Summary: public We recently updated the `ScrollResponder.scrollResponderScrollTo` method to accept an `animated` argument, and deprecated the `scrollResponderScrollWithoutAnimationTo` method. This change was reflected in the native iOS implementation, but not on Android. This diff updates the Android ScrollViewManager implementation to match the JS API, and removes the platform-specific fork in the JS code. Reviewed By: dmmiller Differential Revision: D2883515 fb-gh-sync-id: e5a0e1cf470e21af837b2311cf1048162ac3aff5
Reviewed By: mkonicek Differential Revision: D2881830 fb-gh-sync-id: fef9176964892c5aa40633c177f1d5d8e3aed499
Add buck build folders to gitignore
Summary: We were executing all the updateBlocks for every frame that was updated in the UI flush. This would quickly give you an explosive number of block calls when loading complex views. This update block is only really used by text to propagate padding, even though the actual insets are mostly just 0. public Reviewed By: nicklockwood Differential Revision: D2848968 fb-gh-sync-id: e43c529c2bb9729e2b779bf4abefeed58775cc2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.